Attention is currently required from: daniel, laforge, osmith, pespin. Hello Jenkins Builder, daniel, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel Change subject: ss7_vty: Avoid adding route to local PC in role ASP ...................................................................... ss7_vty: Avoid adding route to local PC in role ASP This commit basically reverts b4f1b2cb8bd404f08601dc8ca700b672a455846c from ~4 years ago. In ASP role, the routing-key is configured with a local PC, since that's what's announced during RKM towards the SG. Hence, it makes no sense adding a route pointing to a local PCm because the M3UA routing decisions first check if the DPC is local, and only then otherwise tries to route it. Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb --- M src/ss7_as_vty.c M src/ss7_vty.c M src/ss7_vty.h 3 files changed, 1 insertion(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/79/40579/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb Gerrit-Change-Number: 40579 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>