Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/40236?usp=email ) Change subject: docs: Better python doc-strings for better pySim.esim manual ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/esim/saip/templates.py: https://gerrit.osmocom.org/c/pysim/+/40236/comment/e8e68213_b1ccdae9?usp=em… : PS1, Line 243: created_by_default = True : This looks weird. Copy-paste? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8 Gerrit-Change-Number: 40236 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 08:36:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes