Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ......................................................................
Patch Set 14: Code-Review+1
(2 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/02ce8f35_533239e2 PS6, Line 675: ional: import
I think it's related: we arrange comments to match the sequence of message parts.
Ack
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/f50a942c_6262958e PS14, Line 603: if (conn->opt_data_cache->cb[0] != exp_type) cosmetic: we use curly braces around multi-line blocks, even if it's only a single statement within the block. that should be linux kernel coding style, too.
-
laforge