Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31165 )

Change subject: tunmap: refactor nft ruleset: fix "martians" and "1024" ......................................................................

Patch Set 3:

(3 comments)

File src/osmo-upf/upf_nft.c:

https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/97a7e718_ce588aea PS3, Line 144: uint32_t chain_id; where's the mark id?

https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/c36a4b5f_939d7ca4 PS3, Line 231: * delete chain inet osmo-upf tunmap-pre-1230 The example above (tunmap_add_single_direction) uses 123 but you use 1230 here.

https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/28a4db6d_d0ba6198 PS3, Line 345: static uint32_t chain_id_next()

Bad function definition - uint32_t chain_id_next() should probably be uint32_t chain_id_next(void)

Please fix.