Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34112 ) Change subject: asp: Monitor SCTP_PEER_ADDR_CHANGE events to re-apply configured Primary Address ...................................................................... Patch Set 3: (3 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/8d868c9e_b8fe5409 PS3, Line 1529: anoter another https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/959aabfa_f3dc7b48 PS3, Line 1529: is was (this is important for understanding this IMHO, another address was made primary before and here it gets replaced with the primary address configured via VTY) https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/139f0143_c1b18dd1 PS3, Line 1558: } IMHO this is hard to read, might be worth refactoring to: * return early if notif->sn_paddr_change.spc_state is not relevant * figure ev_addr and compare it with primary configured in VTY * then depending on spc_state do things if it is the same as the vty configured primary address or not -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I2e54e6f9e424350474db6dec6ab604b33a03f88b Gerrit-Change-Number: 34112 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment