Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo_ss7.c:

  • Patch Set #3, Line 1529: anoter

    another

  • Patch Set #3, Line 1529: is

    was (this is important for understanding this IMHO, another address was made primary before and here it gets replaced with the primary address configured via VTY)

  • Patch Set #3, Line 1558: }

    IMHO this is hard to read, might be worth refactoring to:

    • return early if notif->sn_paddr_change.spc_state is not relevant
    • figure ev_addr and compare it with primary configured in VTY
    • then depending on spc_state do things if it is the same as the vty configured primary address or not

To view, visit change 34112. To unsubscribe, or for help writing mail filters, visit settings.