Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 )
Change subject: rate_ctr: update estimation code ......................................................................
Patch Set 6:
(3 comments)
File src/rate_ctr.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1448): https://gerrit.osmocom.org/c/libosmocore/+/30304/comment/f50b6872_7710d15a PS6, Line 358: if (first_fired[intv]) suspect code indent for conditional statements (24, 31)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1448): https://gerrit.osmocom.org/c/libosmocore/+/30304/comment/3e7acf0e_380ac450 PS6, Line 359: estimate_longer_rate(&ctrg->ctr[i], intv); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1448): https://gerrit.osmocom.org/c/libosmocore/+/30304/comment/2ee91f0b_dabb5798 PS6, Line 359: estimate_longer_rate(&ctrg->ctr[i], intv); please, no spaces at the start of a line