Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39006?usp=email )
Change subject: gsup_client: Avoid double memset 0
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Oh nice, now with the new suggested approach tests are failing here.
You know what, I think I'll simply abandon this patch, I just wanted to submit a quick improvement while reading the code.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/39006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I66515fc893ffc64a36abedc01a75b57aed7e932d
Gerrit-Change-Number: 39006
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 04 Dec 2024 13:37:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No