Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 )
Change subject: pgw: Add TC_gy_charging_cc_time ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2:
ping
Huh, the two comments I left were not marked as Resolved, so I thought they're not addressed.
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0b81d6cd_5ec5c... PS1, Line 688: /* create a session, then execute a ping command on the user plane */
This test is not only about creating session and running ping, right? This comment needs to be clari […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0000a7f1_f9694... PS1, Line 715: control {
Is it intentional that you don't add TC_gy_charging_cc_time to the control section?
Done
-
fixeria