neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29095 )

Change subject: pfcp_msg: check use count correctness ......................................................................

pfcp_msg: check use count correctness

Related: CID#275414 Related: SYS#5599 Change-Id: I685855da8b6f373fdc62a3c75f7f2e0af2839617 --- M src/libosmo-pfcp/pfcp_msg.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: fixeria: Looks good to me, approved

diff --git a/src/libosmo-pfcp/pfcp_msg.c b/src/libosmo-pfcp/pfcp_msg.c index 098ffa2..ff8860a 100644 --- a/src/libosmo-pfcp/pfcp_msg.c +++ b/src/libosmo-pfcp/pfcp_msg.c @@ -455,13 +455,13 @@ { OSMO_LOG_PFCP_MSG(m, LOGL_DEBUG, "discarding\n"); if (m->ctx.session_use_count) - osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, -1); + OSMO_ASSERT(osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, -1) == 0); m->ctx.session_fi = NULL; m->ctx.session_use_count = NULL; m->ctx.session_use_token = NULL;

if (m->ctx.peer_use_count) - osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, -1); + OSMO_ASSERT(osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, -1) == 0); m->ctx.peer_fi = NULL; m->ctx.peer_use_count = NULL; m->ctx.peer_use_token = NULL;

null-- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I685855da8b6f373fdc62a3c75f7f2e0af2839617 Gerrit-Change-Number: 29095 Gerrit-PatchSet: 2 Gerrit-Owner: neels nhofmeyr@sysmocom.de Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de Gerrit-MessageType: merged