Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/c974108c_a1eacc3b PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
My opinion is that in 88% of the code we use alloc+free, so in general those named _del should be mo […]
The existing euse_del() and ussd_route_del() functions don't have those "free" semantics you just stated: instead they require the pointer to be valid (not NULL) and they perform the llist_del() step (unlinking from the global lists of EUSEs and USSD routes) before the final talloc_free(). My new smsc_del() and smsc_route_del() functions are exactly the same.
-
falconia