[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT - gerrit-log

27 Sep 2024

Attention is currently required from: falconia.

fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )

Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3: 
...
  Unfortunately this approach cannot work because bit E7
simply does not exist in NT mode: [... 
Hm, then Harald's code in `gsmtap_csd_rlp_process()` should also be wrong.

...
  The only correct solution is to extend the internal
API to csd_v110_rtp_encode() and pass a flag that indicates alignment with TDMA multiframe
structure. 
Yes, such a flag can be calculated from current TDMA Fn then.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3
Gerrit-Change-Number: 38301
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Comment-Date: Fri, 27 Sep 2024 07:09:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt;