dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38942?usp=email ) Change subject: contrib: remove pysim job from jenkins.sh ...................................................................... contrib: remove pysim job from jenkins.sh The "pysim" job in jenkins.sh has the purpose to check if a change in pyosmocom breaks some functionality in pysim. However, this check has a high risk of creating some kind of circular dependency (chicken-egg problem) between pyosmocom and pysim. The problem occurs when a fix/change in pyosmocom affects the unittests-output of pysim. Then the pysim job will always fail and it is also impossible to submit a complementary fix for pysim as well, since it will always build against the non-fixed pyosmocom library. So, let's remove the pysim job. In case we break functionality in pysim, we will notice it through the nightly builds of pysim and we can take action against the problem like we do it with all other osmocom projects. Related: OS#6598 Change-Id: I5c625229bbfe3944521d3d835b74f20941d3922d --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/42/38942/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e5f8147..78c7fb2 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -48,30 +48,6 @@ make -C "docs" publish publish-html fi ;; -"pysim") - # Run the pysim tests with pyosmocom from this tree (OS#6570) - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate - pip install . --force-reinstall - deactivate - - # Clone pysim and remove pyosmocom from requirements.txt, we want to - # use the version that was just installed into the venv instead - rm -rf pysim - git clone https://gerrit.osmocom.org/pysim --depth=1 --branch=master - cd pysim - sed -i '/^pyosmocom>=.*/d' requirements.txt - if grep -q pyosmocom requirements.txt; then - cat requirements.txt - set +x - echo "ERROR: failed to remove pyosmocom from pysim's requirements.txt" - exit 1 - fi - - # Let pysim enter the same venv and run the tests - ln -s ../venv . - SKIP_CLEAN_WORKSPACE=1 JOB_TYPE="test" contrib/jenkins.sh - ;; *) set +x echo "ERROR: JOB_TYPE has unexpected value '$JOB_TYPE'." -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I5c625229bbfe3944521d3d835b74f20941d3922d Gerrit-Change-Number: 38942 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>