Attention is currently required from: laforge, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31631
)
Change subject: bsc_test.c: test FSM IDs that contain pchan names
......................................................................
Patch Set 8:
(2 comments)
File tests/bsc/bsc_test.ok:
https://gerrit.osmocom.org/c/osmo-bsc/+/31631/comment/ed32bc9b_ebcbf25d
PS3, Line 50: pchan=OSMODYN:
I personally prefer having "-" or
"_" in it, I agree with Harald that "OSMODYN" looks difficult to u […]
Done
File tests/bsc/bsc_test.ok:
https://gerrit.osmocom.org/c/osmo-bsc/+/31631/comment/c320f70c_612e371f
PS8, Line 53: OSMO_DYN
...and this is changed in the next patch
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31631
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If369f23fa140b9d7792f5a511815cbbd14b371e9
Gerrit-Change-Number: 31631
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Mar 2023 02:06:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment