Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28086 )

Change subject: measurement: fix matching of SUB frames by TDMA FN ......................................................................

Patch Set 1:

(3 comments)

File src/common/measurement.c:

https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/96cb455c_8d48a5cc PS1, Line 23: /* TCH/H(0): 0, 2, 4, 6, 52, 54, 56, 58 */

Maybe use ";" to separate between the 2 blocks, it's easier to understand: […]

In this comment it's just a set of FNs copied from 3GPP TS 45.008 as-is. Blocks with the respective FNs they consist of are listed below this comment. I don't think a semicolon makes sense here.

https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/fd642245_a8d7b4af PS1, Line 26: /* TCH/H(1): 14, 16, 18, 20, 66, 68, 70, 72 */

same

Same here, blocks are listed below. This is one-to-one copy from 3GPP TS 45.008.

https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/ac4879d4_c7c4c3ec PS1, Line 65: * There is only one *complete* block in this subset starting at FN=52.

So you first say there's a complete block starting at FN=52, but in next line you say the one starti […]

The first FN of incomplete block {52, 53, 54, 55} is actually several FNs earlier, because on TCH/F every block is interleaved over 8 consecutive bursts. But in DTXu mode, the MS does not transmit the first 4 bursts - that's why I am not listing them in square brackets. Maybe saying {... 52, 53, 54, 55} and {56, 57, 58, 59 ...} would make it cleaner?