Attention is currently required from: falconia, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email ) Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE ...................................................................... Patch Set 2: (1 comment) File src/gsm/gsm0808.c: https://gerrit.osmocom.org/c/libosmocore/+/36669/comment/8b8d0a0b_650f55b8 PS1, Line 2316: [GSM0808_IE_THEMWI_RTP_EXTENSIONS] = { TLV_TYPE_TV }, @falcon@freecalypso.org do you mean that you already have it deployed & working with a TV instead of TLV somewhere? Unless this is deployed in tons of places in production, I'd say let's change this to TLV. I think others also agreed TLV is a better solution here. I'd say let's better see the whole patchset using this new IE before merging stuff in steps. So let's not split this patch in even more patches but keep the 2 definitions together. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c Gerrit-Change-Number: 36669 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 16:04:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment