Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30288 )
Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number
......................................................................
Patch Set 1:
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30288/comment/73a7143c_9dbf3d14
PS1, Line 651: .tn = buf[0] & 0x07,
shouldn't you check the buf[0] is < 8 here?
No, because theoretically there can be version info in this octet.
We may add support for other TRXD versions later.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30288
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb
Gerrit-Change-Number: 30288
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Nov 2022 11:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment