Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email )
Change subject: osmo_io: Massive improvement of API documentation
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/452c94d2_364a7635
PS4, Line 73: differnent
typo: different
Done
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/4d15fe17_38e44abf
PS4, Line 831: * queue. The iofd tself is not freed and can be assigned a new file descriptor with osmo_iofd_register()
typo: itself
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c
Gerrit-Change-Number: 36288
Gerrit-PatchSet: 5
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment