Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 )
Change subject: gmm: Initial implementation of GPRS Detach
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/7c1c11e0_8e1b6bbe
PS1, Line 11: implementation, initial Tx and Rx of some GMM messages, etc.
(would probably be easier to review if this was split
into multiple patches, but I guess you had a r […]
This is all really an initial
implementation filling up base code in several places. I just submit the bunch of
improvements every now and then when I have another feature more or less filled.
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/72f828ed_0812dd8c
PS1, Line 376: /* TODO:
kept this on purpose?
Yes, I still need to find
out how to fill up those. I'm writing now most of the bulk code so that later on each
detail like this one can be improved/fixed in parallel with others.
https://gerrit.osmocom.org/c/libosmo-gprs/+/32050/comment/eb32f629_adc5d424
PS1, Line 471: force_stanbdy_indicated
typo in standby
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/32050
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If6cbb1d425b3a9f713348f1dea4747e2b6be0a44
Gerrit-Change-Number: 32050
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Mar 2023 15:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment