Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39747?usp=email ) Change subject: [6/6] personalization: refactor SdKey ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39747/comment/5f8e7d84_46dc025f?usp=em… : PS3, Line 296: def _apply_sd(cls, pe: ProfileElement, value): If you want to make this method more private you can apply __ underscores instead of one _. (__ is still not a real private method, but the name mangling will give it a nasty prefix) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I427ea851bfa28b2b045e70a19a9e35d361f0d393 Gerrit-Change-Number: 39747 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 15:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No