Attention is currently required from: Hoernchen.

Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email )

Change subject: add fw update crcstub ......................................................................

Patch Set 5:

(9 comments)

File crc_code.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ff340844_b7fe43d0... : PS5, Line 18: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/46e4804a_1e9ba11a... : PS5, Line 20: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ac95337b_3ee43f0a... : PS5, Line 45: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/85a5e7c0_d460d96f... : PS5, Line 61: while (1) suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/063505c2_3138e5b3... : PS5, Line 74: if (argc != 4) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/1a40183c_3876a995... : PS5, Line 86: if (!f) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/f5ef2d54_2fa60823... : PS5, Line 92: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/90dab0dd_305d0f79... : PS5, Line 99: if (!buf) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7d6613cb_3ba918f4... : PS5, Line 108: if (read_bytes != length) { suspect code indent for conditional statements (2, 4)