Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 )
Change subject: bssmap_handle_ass_req_ct_data: implement ......................................................................
Patch Set 2:
(3 comments)
File src/osmo-bsc/codec_pref.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/918a15ee_6af94be3 PS2, Line 117: gsm0804
gsm0408, not gsm0804. 04.x is radio/Um interface, while 08.x is RAN interfaces like Abis or A.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/04eeac17_fa82a25b PS2, Line 137: sm0804
likewise here, gsm0408. or gsm48 if you want to stay like the enum/constant values.
Done
File src/osmo-bsc/osmo_bsc_bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/28a388cb_ffc4bf9d PS2, Line 677: select_codecs_data
FYI, it's not really a 'codec' in the data case, but a "rate". […]
agreed, renamed the functions and moved them to data_rate_pref.c
-
osmith