Attention is currently required from: osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27468 to look at the new patch set (#2). Change subject: bsc_nat_fsm: drop LOG_SCCP macro ...................................................................... bsc_nat_fsm: drop LOG_SCCP macro After implementing more functionallity (see follow-up patches), it became clear that this macro is not so useful: * Using the macro creates unnecessary overhead, 'LOG_SCCP(sccp_inst, peer_addr_in,' is much longer than 'LOGP(' * The RI and SSN are always the same, so it's not useful to print them all the time, this is the generated prefix: '(RI=SSN_PC,PC=0.23.3,SSN=BSSAP from CN)' Related: SYS#5560 Change-Id: I49187d4e3d804c4786ee52eaebdd911e6c6cfa6c --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 6 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/68/27468/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I49187d4e3d804c4786ee52eaebdd911e6c6cfa6c Gerrit-Change-Number: 27468 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset