Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 10: (6 comments) File include/osmocom/gtp/gsn.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/7daac752_274d7768?us… : PS10, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/a6be551b_9cb9e501?us… : PS10, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/192557dd_bc77ad4d?us… : PS10, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/34c8f2a6_94d154a6?us… : PS10, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e7f4b916_f5367c8b?us… : PS10, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/8a301fad_16e28766?us… : PS10, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 16 Feb 2025 18:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No