Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email )

Change subject: gtp: add support for SGSN Context Req/Resp/Ack ......................................................................

Patch Set 10:

(6 comments)

File include/osmocom/gtp/gsn.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/7daac752_274d7768?usp... : PS10, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/a6be551b_9cb9e501?usp... : PS10, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/192557dd_bc77ad4d?usp... : PS10, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/34c8f2a6_94d154a6?usp... : PS10, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e7f4b916_f5367c8b?usp... : PS10, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21539): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/8a301fad_16e28766?usp... : PS10, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments