Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email )

Change subject: coverity CID#57681 ......................................................................

Patch Set 1:

(11 comments)

File src/OCTET_STRING.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/cfe36650_82216edb?usp=... : PS1, Line 1862: unsigned int unused; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/97fe6402_a5a4218f?usp=... : PS1, Line 1862: unsigned int unused; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/1d859f03_3be2b060?usp=... : PS1, Line 1892: sizeinunits = st->size * 8; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/f291d748_ebc022db?usp=... : PS1, Line 1892: sizeinunits = st->size * 8; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/0a25fb0a_a54146ff?usp=... : PS1, Line 1893: /* make sure sizeinunits cannot wrap past zero (especially when st->size == 0). */ code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/03ac5c4f_0c61fd60?usp=... : PS1, Line 1894: unused = st->bits_unused & 0x07; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/efddbfdd_fc46ebe9?usp=... : PS1, Line 1894: unused = st->bits_unused & 0x07; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/720a0055_527b6e6d?usp=... : PS1, Line 1895: if (unused <= sizeinunits) code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/bc07808d_f3dfc870?usp=... : PS1, Line 1895: if (unused <= sizeinunits) please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/c8e8d0ae_fd282527?usp=... : PS1, Line 1896: sizeinunits -= unused; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/c8ed72c3_425cf2ec?usp=... : PS1, Line 1896: sizeinunits -= unused; please, no spaces at the start of a line