Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin.

laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email )

Change subject: Use talloc to allocate asn1c decoded structs ......................................................................

Patch Set 2:

(1 comment)

File src/tcap.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/52bb55f1_2327... : PS2, Line 29: vo

Please see follow-up patch https://gerrit.osmocom. […]

it's still inconsistent with how we do it in libasn1c. I prefer consistency unless there are strong reasons against it. Otherwise every bit and piece of code behaves differently despite being the same asn1c runtime. So basically if you want to do it differently, please explain why so we can discuss about it during review. So far it could just be an accidential inconsistency as no reason was provided.

Futhermore, the namespace problem retains as the context is 'extern void'. and we're not using some linker script to hide symbols from exporting. I would say *if* we go for a setter method, then there should be a getter method and no publicly visible context symbol at all.

If we have an exported global variable, a setter or getter makes little sense, IMHO, as anyone can bypass it.