Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35792?usp=email ) Change subject: Add support for M3UA-over-TCP, clarify default SCTP ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: I think the actual functionality is still missing and this just touches VTY bits? should maybe be a WIP patch? File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/35792/comment/7b4e0c2c_659a13f5 PS1, Line 106: sctp please don't do that. our osmo-stp config/vty syntax is closely modelled after how cisco ITP works (worked). Let's not introduce incompatibilities that way. M3UA Is always SCTP everywhere. Using it over TCP is highly unusual. So I think we should only mention TCP when it is the non-standard case. Also, we really don't want to create the impression of our config files changing [despite the backwards compatibility] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I078da51abc3511a4854f9c8fbca8eafd2bed78da Gerrit-Change-Number: 35792 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Feb 2024 22:31:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment