Attention is currently required from: daniel, jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email )
Change subject: osmo_io_uring: Detach msghdr from iofd before calling
iofd_handle_send_completion()
......................................................................
Patch Set 4:
(3 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/6e1903f0_dfe8c37c
PS4, Line 199: * If there is pending data to sent, iofd_uring_submit_tx will attach it
again.
to send
https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/cd22fe2e_01046fff
PS4, Line 201: * iofd (which in turn frees this msghdr, if still attached) and frees the
msghdr, causing a double free. */
"(which in turn frees this msghdr, if still attached) and frees the msghdr".
you are repeating yourself here?
https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/4f084d16_4f109c36
PS4, Line 210: }
where does the second free happen? in iofd_uring_submit_tx?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07
Gerrit-Change-Number: 35982
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment