Attention is currently required from: osmith, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 )

Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ......................................................................

Patch Set 3:

(1 comment)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/b99acf52_ce71fc66 PS1, Line 552: if (pch->confirmed_imm_ass)

I don't think that it is required to mention this, we do changes to PCUIF all the time. […]

I disagree with this. I'm now more or less understanding the different changes you are doing to the protocol, but even for myself it's starting to be confusing the amount of changes. Imagine for others, or ourselves in a few months time. It will be difficult to understand which changes are part of which versions of the protocol. So yeah, in general I'd love seeing a bit more thoughts and clear explanations on what these changes are part of (eg v10->v11 changes).