Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email )
Change subject: RTP: add vty option for ortp vs twrtp selection ......................................................................
Patch Set 5:
(2 comments)
File src/common/vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/ad5a44e4_8ae46c69?usp=... : PS5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) {
my implementation only one line of code will need to change at that point
same with the other approach, where
if (bts->use_twrtp) vty_out(vty, " rtp library twrtp%s", VTY_NEWLINE);
becomes
if (!bts->use_twrtp) vty_out(vty, " rtp library ortp%s", VTY_NEWLINE);
--disable-ortp
When that's added (soon I hope :P) simply add an extra #ifdef HAVE_ORTP around those lines.
https://gerrit.osmocom.org/c/osmo-bts/+/42167/comment/1644d785_fc3a6744?usp=... : PS5, Line 1529: vty_out(vty,
Considering our already set plan to change the default at some point in the not too distant future, […]
I understand your point, but this simply deviates for how all the other N-thousand parameteres we have in the code, because otherwise we'd need to have tons of global variables and it's something I'd like to avoid to make the code more complex.
If a user wants to figure out the default, simply drop the config and start the program + use vty, or look at the code, or the user manual.
So my opinion on this is that this patch should follow similar ways as done for all the other N-thousand params, otherwise it's more hassle to maintain. It also creates different expectancies for users in relation to the other parameters. If others are fine with having it this way though, I won't oppose.
-
pespin