Attention is currently required from: laforge, neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email )

Change subject: per-HNB GTP-U traffic counters via nft ......................................................................

Patch Set 17:

(1 comment)

Patchset:

PS3:

Kindly state your reason for this statement, it seems unqualified to me.

I already mentioned it in several places, even before you started writing any related code (Yes, I took the time to do so before you started coding by providing links to osmo_itq several times because I thought it would be helpful). The main loop should not be blocked. Running the nft command in blocking mode inside the main loop thread is not nice.

So having this merged means we end up with code blocking the main loop in current master, which is not desirable.

every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it.

In line with the lately "it's bikeshed" and "it's your opinion" comments, even if I'm not the only one stating it. I'll let others take care of this then, to avoid continuing with the "downplaying".