Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336 )

Change subject: hnb_context_release(): Make sure assigned conn is freed ......................................................................

Patch Set 1: Code-Review+1

(5 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/a66199dc_88ac2030 PS1, Line 13: life life is life?

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/fa35410a_db07b3f5 PS1, Line 14: synchronous isn't release always async, because it involves messages to/from remote?

File src/osmo-hnbgw/hnbgw.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/b6f592a2_76d82cb4 PS1, Line 304: return 0; /* hnb_context is being freed, nothing do be done */ (i thought now it is just hnb->hnb_registered == false?)

("hnb_context is being freed" seems inaccurate, the hnb already *is* NULL, long gone)

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/a2685d20_29cafd22 PS1, Line 306: /* hnb: conn became broken, let's release the associated hnb. maybe "conn closed on an active hnb_context" ... then again, if hnb_registered == false then this could be the usual code path, i.e. neither broken nor still active?

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/5aeabc6c_fb836877 PS1, Line 374: to call calling