Change in osmo-pcu[master]: Get rid of tbf->first_ts - gerrit-log

15 Dec 2022


      Attention is currently required from: pespin, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30568 )
Change subject: Get rid of tbf->first_ts
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/tbf.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/97d2b223_7d5e02ce 
PS1, Line 899: 8
...
This loop formula is used in lots of places in osmo-pcu already, but yeah, I can update it to use ARRAY_SIZE.
yes, it goes unfortunately back to the very early/first osmo-pcu codebase which was full of magic numbers at least for iterators.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30568
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5d2f665f648f8637466bfdd3bf7b924cb61ede33
Gerrit-Change-Number: 30568
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 15 Dec 2022 19:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment