Attention is currently required from: fixeria, laforge, osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )

Change subject: SIP_Emulation: Rename component id ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/ba0f81d0_3e25c... PS1, Line 9: it makes it impossible to reference the : component name under TESTPORT_PARAMETERS

If renaming stuff & refactoring code is easier for you, then I have nothing to say :D

Is already done anyway, so nothing really to discuss about regarding this hypothesis I think.

The point now is that: * This new name makes it easier to relate to the component owning the name (SIP_Emulation). * This new new doesn't need to be escaped when used in config files.

I don't see a connection with the component name escaping.

Because ofc spaces also need to be escaped, which causes trouble.

The problem, though, is that this patch brings inconsistency to the code.

I think you are still talking about some imaginary name consistency plan/architecture done by a brilliant mind when writing all testsuites here. I don't think there was ever such a a plan nor was brought up by anyone.

I don't see a point to it anyway, since the components can be used differently in different testsuites.