Attention is currently required from: falconia. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Cool, I never considered / tried Call Waiting before. It would be great to see some ladder diagram or somesuch for the scenario that this patch fixes, if you can spare the time. We also have this script that makes ladder diagrams from reading an osmo-msc log. Unfortunately it seems I forgot to document the logging configuration that this needs, I'm guessing: log file /tmp/osmo-msc.log logging filter all 1 logging color 0 logging print level 1 logging print category 1 logging print category-hex 0 logging print file basename last logging print extended-timestamp 1 logging level set-all debug and then run your call-waiting scenario. After that, get a ladder diagram from the log file with these two lines: ~/src/osmo-msc/doc/sequence_charts/msc_log_to_ladder.py -i /tmp/osmo-msc.log -o /tmp/foo.msc mscgen -T png -o foo.png /tmp/foo.msc You could add that foo.msc diagram, as part of this patch, to osmo-msc/doc/sequence_charts, next to the other ones that illustrating the order of things in various kinds of voice calls. All this is optional, but it would help me a lot to understand the context. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibb62cb3c154b99769b2dfe708f73c20e8b632f5d Gerrit-Change-Number: 29973 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 22 Jun 2023 21:43:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment