Attention is currently required from: neels, laforge, pespin, fixeria, dexter. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 )

Change subject: Expand VTY option which controls use of TCH for signalling ......................................................................

Patch Set 9:

(2 comments)

File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/2260fcd7_6ba924cf PS8, Line 2182: (bts->chan_alloc_tch_signalling_policy == BTS_TCH_SIGNALLING_VOICE &&

Alignment should be done using a few spaces to end up under "b" character here from previous line he […]

Picky is good. Picky pays off in the long run.

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/d80973ef_5de409c4 PS8, Line 593: DEFUN_DEPRECATED(cfg_bts_chan_alloc_allow_tch_for_signalling,

Better use DEFUN_ATTR(... […]

Ah, thanks. I wasn't really sure of the differences in that set of macros and defines.