Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33446 )
Change subject: ASCI: Add decoding of mobile identity in TALKER INDICATION
......................................................................
Patch Set 1:
(2 comments)
File src/gsm/gsm48.c:
https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/982a0fe4_d6a5e1e0
PS1, Line 959: if (l3_len < sizeof(*gh) + 4 + 2)
what are this offsets?
This is the minimum
message size according to TS 44.018 9.1.44.
https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/a7f59606_fc57b1ca
PS1, Line 961: if (gh->data[0] != 3)
what's this value about?
This is the fixed
length of the first IE.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33446
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d
Gerrit-Change-Number: 33446
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 09:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment