Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30183 ) Change subject: firmware/sniffer: Group global variables in structs ...................................................................... Patch Set 1: (1 comment) File firmware/libcommon/source/sniffer.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1052): https://gerrit.osmocom.org/c/simtrace2/+/30183/comment/5aee55d6_85ac3b26 PS1, Line 479: if (ATR_S_WAIT_TC == g_atr.state && 2==i) { spaces required around that '==' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3e02f6c6b063ebc860b7a2a54dfc6051f1ea584f Gerrit-Change-Number: 30183 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 16 Nov 2022 11:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment