Attention is currently required from: fixeria, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email )

Change subject: msc: f_expect_paging(): better detect failure ......................................................................

Patch Set 1:

(1 comment)

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/dbe2fb96_4b7f0... PS1, Line 1366: if (g_pars.ran_is_geran) {

Ack, and f_expect_paging can actually be an altstep.

Instead of going into this code again i'd rather drop this mild convenience patch that only helps when osmo-msc is buggy, i.e. quite soon never. I see how your feedback can make sense but it is simply not worth the effort, let's not idealize our test suite.

On a larger scale: I don't like that ttcn3 forces us to build up these alt-steps-with-timers and catching non-matching messages, all over the place. Instead we should implement and apply a generalized soultion for this, sort of like f_rua_expect() functions. So instead of spreading these constructs over and over again, we should find a way to *generally* fix our test suite usability.

So, no, I disagree very much with going into these bike sheds.