Attention is currently required from: JPM, dexter, laforge.
Jenkins Builder has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter.
......................................................................
Patch Set 3:
(1 comment)
File tests/test_construct.py:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19794):
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/3b49fcdf_986c7... :
PS3, Line 115:
trailing whitespace
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
Gerrit-Change-Number: 38687
Gerrit-PatchSet: 3
Gerrit-Owner: JPM
jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: JPM
jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 08 Nov 2024 16:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No