Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28325 ) Change subject: bts_chan_load(): also calculate per-TRX channel load ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/chan_alloc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/33aeb96b_80de2535 PS1, Line 47: struct load_counter *ll = &trx->lchan_load; I wonder what ll means here. https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/47af5698_b0b46c82 PS1, Line 85: ll->total++; You can simply do: ll->total += pl->total; ll->used += pl->used; after the loop, instead of doing +1 N times. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I220145238c23135f7e68ca2d474764312ffb66c5 Gerrit-Change-Number: 28325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment