Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 ) Change subject: asn1tostruct: fix defines getting redefined ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS4: re-applying and combining votes after rebase File asn1/utils/asn1tostruct.py: https://gerrit.osmocom.org/c/osmo-iuh/+/30088/comment/03f8c5f3_44c3c42a PS3, Line 84: use the same type multiple times, in that case we use the actual name Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 10:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment