Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 ) Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ...................................................................... Patch Set 3: (4 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/15267516_6afa8c8d PS3, Line 1285: if (idx_primary >= (int)host_cnt) Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/0260c48a_0ca30e14 PS3, Line 1382: is_primary Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/230a12f9_b41271d4 PS3, Line 1402: an Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/75e8a261_6f4c80ec PS3, Line 2067: rc = yeah, but I don't really want the entire connection to fail if this feature is not supported (may happen in older kernels). It's fine the way it is now IMHO. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca Gerrit-Change-Number: 34111 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment