Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 )
Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ......................................................................
Patch Set 3:
(4 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/15267516_6afa8c8d PS3, Line 1285: if (idx_primary >= (int)host_cnt)
How about: […]
Ack
https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/0260c48a_0ca30e14 PS3, Line 1382: is_primary
is_primary_addr
Ack
https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/230a12f9_b41271d4 PS3, Line 1402: an
"an" is wrong here
Ack
https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/75e8a261_6f4c80ec PS3, Line 2067: rc =
previous rc gets overwritten here (check it before?), same in xua_accept_cb()
yeah, but I don't really want the entire connection to fail if this feature is not supported (may happen in older kernels). It's fine the way it is now IMHO.