Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 3: (4 comments) File include/osmocom/vty/command.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/51bd5200_6004bf40 PS3, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status); "foo * bar" should be "foo *bar" File src/select.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/4936fc83_faa99cce PS3, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line File src/vty/cpu_sched_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/e58d21ac_a7eb1ca5 PS3, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line File tests/gsm0808/gsm0808_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/a6f3dc70_3ebfad8e PS3, Line 1482: void test_cell_id_list_add(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment