Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email )

Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2: what I don't yet see is any attempt to increase the UDP socket send buffer using SO_SNDBUF. On my debian unstable system the default size (wmem_default) is 212992 while the maximum permitted (if an application bothers to use SO_SNDBUF) is 10485676 almost a five-fold increase.

I guess we should have some libosmocore function that reads wmem_max at program initialization time and caches it in a global variable, and then a user-callable function for "set socket buffer to maximum permitted by the OS". The latter should then be used for any UDP sockets that see a lot of transmit traffic, like TRXD and gsmtap-log.

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/4dc50a0b_dc325929?u... : PS2, Line 818: "Use non-blocking, synchronous I/O (may lose msgs if UDP sndbuf becomes full)\n" s/sndbuf/socket transmit buffer/ or s/sndbuf/socket send buffer/ ?