[S] Change in libosmo-sccp[master]: Set stream_cli/srv name to contain ASP + sockname - gerrit-log

21 Jun 2023

Attention is currently required from: osmith, pespin, daniel.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/33335 )

Change subject: Set stream_cli/srv name to contain ASP + sockname
......................................................................

Patch Set 9: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33335/comment/9ccfb7f1_1ae24d52 
PS6, Line 21: asp0,(r=::1:2905<->l=::ffff:127.0.0.2:35911)
...
  I think the example is now wrong (_ instead of ,). […]
Done

File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33335/comment/f6f6311f_87750505 
PS5, Line 2102: ,%
...
  I think that comma may later end up in FSM names which
might in turn get exported via CTRL or counte […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33335
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I05bc5f6c7795f62c1814c1c774287b41ee85a475
Gerrit-Change-Number: 33335
Gerrit-PatchSet: 9
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 21 Jun 2023 10:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-MessageType: comment