laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34061 )

Change subject: BTS_Tests: call f_pcu_data_req with correct timeslot ......................................................................

BTS_Tests: call f_pcu_data_req with correct timeslot

We are calling f_pcu_data_req() with SAPI PCU_IF_SAPI_AGCH or SAPI PCU_IF_SAPI_PCH and use ts_nr 7.

In this particular case, the parameter ts_nr has no effect (see pcu_sock.c in osmo-bts.git). However, to prevent confusion, lets use ts_nr 0 since AGCH and PCH are actually is on TS 0 (on TRX 0).

Related: OS#5927 Change-Id: I20566de992809d6c857c9062bf0fb799efa43e45 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 3 deletions(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 3602746..93b0ddf 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5792,7 +5792,7 @@ f_l1_tune(L1CTL);

f_TC_pcu_act_req(0, 0, 7, true); - f_pcu_data_req(0, 0, 7, 0, 0, PCU_IF_SAPI_AGCH, c_PCU_DATA); + f_pcu_data_req(0, 0, 0, 0, 0, PCU_IF_SAPI_AGCH, c_PCU_DATA);

T.start; alt { @@ -5817,13 +5817,13 @@

if (mp_pcuif_version < 11) { /* three characters prefix: last 3 digits of IMSI as ASCII */ - f_pcu_data_req(0, 0, 7, 0, 0, PCU_IF_SAPI_PCH, '313233'O & c_PCU_DATA); + f_pcu_data_req(0, 0, 0, 0, 0, PCU_IF_SAPI_PCH, '313233'O & c_PCU_DATA); } else { var PCUIF_pch_dt pch_dt; pch_dt.tlli := '01020304'O; pch_dt.imsi := "00101000000000123"; pch_dt.data := c_PCU_DATA; - f_pcu_data_req(0, 0, 7, 0, 0, PCU_IF_SAPI_PCH_DT, enc_PCUIF_pch_dt(pch_dt)); + f_pcu_data_req(0, 0, 0, 0, 0, PCU_IF_SAPI_PCH_DT, enc_PCUIF_pch_dt(pch_dt)); }

T.start;