Attention is currently required from: osmith, Hoernchen, neels, laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 ) Change subject: Add osmo_io with initial poll backend ...................................................................... Patch Set 14: (6 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/5f8e6f97_4bec484d PS14, Line 150: msg = iofd->pending; use `msg = iofd_msgb_pending(iofd)` here? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/d2ae9a37_d45f3a58 PS14, Line 324: flags `sendto_flags` https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/e3c76b19_80f9ef5b PS14, Line 516: underlyiny typo: underlying File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/8220d3f6_846c09cc PS14, Line 40: /*! flags to guard closing/freeing of iofd */ Not saying this needs to be done, but IMO a bitmask would be a better fit here because adding new flags would not require adding new fields and thus breaking ABI. File src/core/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/96c515c9_320de74b PS14, Line 44: inline Do we really need to force inlining here? Given that this function is used only once, compilers will likely inline it anyway... https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/3a82b046_20ac5f35 PS14, Line 175: struct iofd_backend_ops iofd_poll_ops = { const? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0 Gerrit-Change-Number: 30934 Gerrit-PatchSet: 14 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 May 2023 22:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment