Attention is currently required from: osmith, Hoernchen, neels, laforge, daniel.

View Change

6 comments:

• File src/core/osmo_io.c:

  • Patch Set #14, Line 150: msg = iofd->pending;

    use `msg = iofd_msgb_pending(iofd)` here?

  • Patch Set #14, Line 324: flags

    `sendto_flags`

  • Patch Set #14, Line 516: underlyiny

    typo: underlying

• File src/core/osmo_io_internal.h:

  • Patch Set #14, Line 40: /*! flags to guard closing/freeing of iofd */

    Not saying this needs to be done, but IMO a bitmask would be a better fit here because adding new flags would not require adding new fields and thus breaking ABI.

• File src/core/osmo_io_poll.c:

  • Patch Set #14, Line 44: inline

    Do we really need to force inlining here? Given that this function is used only once, compilers will likely inline it anyway...

  • Patch Set #14, Line 175: struct iofd_backend_ops iofd_poll_ops = {

    const?

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.